Skip to content

SXT bugfixes and improvements#801

Merged
stephen-riggs merged 15 commits into
mainfrom
sxt-round2
May 19, 2026
Merged

SXT bugfixes and improvements#801
stephen-riggs merged 15 commits into
mainfrom
sxt-round2

Conversation

@stephen-riggs
Copy link
Copy Markdown
Contributor

@stephen-riggs stephen-riggs commented May 15, 2026 •
edited
Loading

Various changes needed to make the SXT workflow smoother:

  • Use olefile directly and remove the txrm2tiff dependency
  • Read energy, tilt limits and tilt count from the txrm metadata and store them in the DataCollection ispyb table
  • Skip processing of reference txrm files
  • Allow processing of nested folders
  • Set session file to None and then tag the DCG with the unaltered metadata path
  • Set the data collection comment as any part of the file name before _angle

The remaining issue is how to set the rsyncers correctly, which we need to discuss

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 68.62745% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.34%. Comparing base (38088f7) to head (e23ed22).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #801   +/-   ##
=======================================
  Coverage   52.33%   52.34%           
=======================================
  Files          96       96           
  Lines       10324    10345   +21     
  Branches     1357     1363    +6     
=======================================
+ Hits         5403     5415   +12     
- Misses       4642     4647    +5     
- Partials      279      283    +4
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stephen-riggs stephen-riggs changed the title SXT fixes SXT bugfixes and improvements May 18, 2026
@stephen-riggs stephen-riggs marked this pull request as ready for review May 18, 2026 15:11
@stephen-riggs stephen-riggs requested review from d-j-hatton and tieneupin and removed request for tieneupin May 18, 2026 15:11
tieneupin
tieneupin reviewed May 19, 2026
View reviewed changes
Comment thread src/murfey/client/contexts/sxt.py
tieneupin
tieneupin reviewed May 19, 2026
View reviewed changes
Comment thread src/murfey/client/contexts/sxt.py
tieneupin
tieneupin reviewed May 19, 2026
View reviewed changes
Comment thread src/murfey/client/contexts/sxt.py
tieneupin
tieneupin reviewed May 19, 2026
View reviewed changes
Comment thread src/murfey/client/contexts/sxt.py
tieneupin
tieneupin reviewed May 19, 2026
View reviewed changes
Comment thread src/murfey/client/contexts/sxt.py Outdated
tieneupin
tieneupin approved these changes May 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@tieneupin tieneupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some requests for clarification, but beyond that, the changes looks good. Nice work!

tieneupin
tieneupin reviewed May 19, 2026
View reviewed changes
Comment thread src/murfey/client/contexts/sxt.py
@stephen-riggs stephen-riggs merged commit f4d7496 into main May 19, 2026
17 checks passed
@stephen-riggs stephen-riggs deleted the sxt-round2 branch May 19, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tieneupin tieneupin tieneupin approved these changes

@d-j-hatton d-j-hatton Awaiting requested review from d-j-hatton

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stephen-riggs @tieneupin